Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty media stream config #1967

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Handle empty media stream config #1967

merged 1 commit into from
Jan 24, 2025

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Jan 17, 2025 •
edited
Loading

Dependent on equinor/isar#698

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Eddasol Eddasol linked an issue Jan 17, 2025 that may be closed by this pull request
Handle missing media-stream silently #1952
Closed
@Eddasol Eddasol self-assigned this Jan 17, 2025
@Eddasol Eddasol added the improvement Improvement to existing functionality label Jan 17, 2025
andchiind
andchiind approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eddasol Eddasol merged commit 21ff50e into equinor:main Jan 24, 2025
11 of 12 checks passed
@Eddasol Eddasol deleted the meadia-stream branch January 24, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

Assignees

@Eddasol Eddasol

Labels
improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle missing media-stream silently
2 participants
@Eddasol @andchiind